additional goodies csv sftp perf sql and more #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of allowing the state to be not recoverable, this will instead fail to render the available variables section only.
keevan
force-pushed
the
additional-goodies-csv-sftp-perf-sql-and-more
branch
from
a996838
to
a9c82ca
Compare
Similar to set_variable but this allows multiple values to be set on an existing or new path. This simplifies initialisation of multiple variables per instance run, such as counters used for reporting.
- The background with white text was difficult to read (low contrast) - The warning regex previously in place was incorrect
Also tweaked comment on string format of run based output logs.
…nment It is more correct to expect the number of fields to match the number of headers, not the other way around necessarily.
…e issues The only one is currently a count mismatch on header and the row fields
keevan
force-pushed
the
additional-goodies-csv-sftp-perf-sql-and-more
branch
from
a9c82ca
to
7ffa407
Compare
Peterburnett
approved these changes
Dec 22, 2023
keevan
force-pushed
the
additional-goodies-csv-sftp-perf-sql-and-more
branch
from
3e637df
to
f7485ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the SFTP one in particular, it was doing about 200ms initial connection time, 600-700ms initial upload time, but otherwise breezing for subsequent SFTP actions, unlike previously.