Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code standards and deprecations #620

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Jul 29, 2024

Changes

  • Cleanup all coding standards and phpdoc warnings. Mostly done via phpcbf + manually converting unit test providers to static functions (after confirming they are truly static, just weren't labelled as such)
  • Removes use of deprecated utf_encode - cherry picked commit from here Remove use of utf8_encode (deprecated in PHP 8.2) #598 - tested in S3 myself, and S3 + cloudfront in the other PR and works as expected, seems equivalent.
  • Removed legacy privacy api polyfill needed because older php versions didn't support typehinting, however, Moodle 3.10 supports Php 7.2 which supports type hinting (params and return types)

To Do

@matthewhilton matthewhilton marked this pull request as ready for review July 29, 2024 22:39
@brendanheywood brendanheywood merged commit 4e04360 into MOODLE_310_STABLE Aug 1, 2024
18 checks passed
@brendanheywood brendanheywood deleted the fix-codestandards branch August 1, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants