Fix code standards and deprecations #620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
phpcbf
+ manually converting unit test providers to static functions (after confirming they are truly static, just weren't labelled as such)utf_encode
- cherry picked commit from here Remove use of utf8_encode (deprecated in PHP 8.2) #598 - tested in S3 myself, and S3 + cloudfront in the other PR and works as expected, seems equivalent.To Do
utf8_encode
replacement and confirm it still works as expected