Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text-on-accent #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

42Willow
Copy link
Member

@42Willow 42Willow commented Oct 13, 2024

edit: just saw your issue, I hope you [the maintainer] are recovering well if you see this ❤️
I will checkout the development branch and may make a pr there instead

  • fixes checkbox styling
  • uses mantle instead of base on top of accents

before and after:
image
image

- fixes checkbox styling
- uses mantle instead of base on top of accents
@42Willow
Copy link
Member Author

42Willow commented Oct 13, 2024

I am a fan of how anuppuccin does the styling for the checkboxes as opposed to this though
image
although, that white on the toggle isn't catppuccin

with ctp-text:
image

@42Willow 42Willow marked this pull request as draft October 13, 2024 10:18
@42Willow
Copy link
Member Author

Marked as draft because this needs to be changed to
image

@42Willow 42Willow changed the title fix: text-on-accent fix: checkbox styling Oct 13, 2024
@mbeckrich
Copy link
Collaborator

mbeckrich commented Oct 13, 2024 via email

@mbeckrich
Copy link
Collaborator

mbeckrich commented Oct 13, 2024

Appreciate your edit, btw! <3 Just waiting on neurology now...

Took a look at the screenshots on my computer, everything looks nice from my perspective. Feel free to keep working on this and update me when it's ready for review. I'm fine with the work being on the main branch and I will make a note to pull it into development when that's ready to get merged. I was doing goofy stuff with the toggles in development, lol.

@42Willow
Copy link
Member Author

I cannot figure out how to use sass to generate the css, it keeps outputting only this:

@use "base/app-variables";
@use "base/ctp-style-settings";
@use "base/typography";
@use "components/animations";
@use "components/callouts";
@use "components/cmd-palette";
@use "components/icons";
@use "components/inputs";
@use "components/links";
@use "components/pdfs";
@use "components/scrollbars";
@use "components/search";
@use "components/status-bar";
@use "layout/header";
@use "layout/sidebar";
@use "layout/tabs";
@use "pages/canvas";
@use "pages/settings";
@use "themes/latte-adjustments";
@use "themes/full-palette";
@use "vendors/plugins";
@use "vendors/fonts";

@42Willow
Copy link
Member Author

I'll make a new PR for the checkboxes if I figure it out

@42Willow 42Willow marked this pull request as ready for review October 14, 2024 08:21
@42Willow 42Willow changed the title fix: checkbox styling fix: text-on-accent Oct 14, 2024
@mbeckrich
Copy link
Collaborator

mbeckrich commented Oct 14, 2024

edit 2x: sorry, what version of sass are you using? There were some changes to @use/@import at some point that may mean an older version of sass won't work with how the theme is setup right now. I am using 1.79.5, fwiw.

edit: also, if you just want to work on the sass files and have me compile them when I go to merge, that's totally fine with me. I have done that for people before without issue.


Thanks, will review soon. If you're still having trouble with sass, are you running sass scss/main.scss theme.css from the root of the repository? You can also try running sass scss/main.scss {{path to your obsidian snippets}}.css, which is what I usually do when I am working on the theme. Then I can use the default Obsidian theme but work on the Catppuccin theme as an enabled snippet. But then you do still have to run that first command in the repository so that everything compiles for the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants