Fix quotes converting free-form syntax to yaml (ansible#4319)

YAML content has been changed to reflect that the YAML loader preserves
quotes used in YAML and to utilize the preferred_quote attribute.

examples/playbooks/transform-no-free-form.transformed.yml

@@ -20,11 +20,12 @@
         executable: /bin/bash
       changed_when: false
 
+    # prettier-ignore
     - name: Example task with usage for '=' as module params
       ansible.builtin.debug:
-        msg: "'Hello there world'"
+        msg: 'Hello there world'
       changed_when: false
 
     - name: Task that has a non-debug string with spaces
       ansible.builtin.set_fact:
-        foo: '"String with spaces"'
+        foo: "String with spaces"

examples/playbooks/transform-no-free-form.yml

@@ -14,6 +14,7 @@
       ansible.builtin.raw: executable=/bin/bash echo foo # <-- don't use executable=
       changed_when: false
 
+    # prettier-ignore
     - name: Example task with usage for '=' as module params
       ansible.builtin.debug: msg='Hello there world'
       changed_when: false

src/ansiblelint/constants.py

@@ -221,6 +221,9 @@ def main():
     ".config/ansible-lint.yaml",
 ]
 
+DOUBLE_QUOTE_PLACEHOLDER = "__double__"
+SINGLE_QUOTE_PLACEHOLDER = "__single__"
+
 
 class States(Enum):
     """States used are used as sentinel values in various places."""

src/ansiblelint/rules/no_free_form.py

@@ -5,11 +5,18 @@
 import functools
 import re
 import sys
+from io import StringIO
 from typing import TYPE_CHECKING, Any
 
-from ansiblelint.constants import INCLUSION_ACTION_NAMES, LINE_NUMBER_KEY
+from ansiblelint.constants import (
+    DOUBLE_QUOTE_PLACEHOLDER,
+    INCLUSION_ACTION_NAMES,
+    LINE_NUMBER_KEY,
+    SINGLE_QUOTE_PLACEHOLDER,
+)
 from ansiblelint.rules import AnsibleLintRule, TransformMixin
 from ansiblelint.rules.key_order import task_property_sorter
+from ansiblelint.yaml_utils import FormattedYAML
 
 if TYPE_CHECKING:
     from ruamel.yaml.comments import CommentedMap, CommentedSeq
@@ -125,6 +132,26 @@ def filter_values(
                     quote = v[0]
                     _, v, remainder = v.split(quote, 2)
                     v = f"{quote}{v}{quote}"
+
+                    preamble_comment: str | None = getattr(
+                        data,
+                        "preamble_comment",
+                        None,
+                    )
+                    with StringIO() as stream:
+                        if preamble_comment:
+                            stream.write(preamble_comment)
+                        FormattedYAML(
+                            version=(1, 1) if lintable.is_owned_by_ansible() else None,
+                        ).dump(data, stream)
+
+                        # quoting was munged by the emitter
+                        if f" {v}" not in stream.getvalue():
+                            if quote == '"':
+                                placeholder = DOUBLE_QUOTE_PLACEHOLDER
+                            else:
+                                placeholder = SINGLE_QUOTE_PLACEHOLDER
+                            v = v.replace(quote, placeholder)
                 else:
                     try:
                         v, remainder = v.split(" ", 1)

src/ansiblelint/yaml_utils.py

@@ -28,8 +28,10 @@
 
 from ansiblelint.constants import (
     ANNOTATION_KEYS,
+    DOUBLE_QUOTE_PLACEHOLDER,
     NESTED_TASK_KEYS,
     PLAYBOOK_TASK_KEYWORDS,
+    SINGLE_QUOTE_PLACEHOLDER,
 )
 from ansiblelint.utils import Task
 
@@ -1182,6 +1184,8 @@ def _post_process_yaml(
             text = text.split("\n", 1)[1]
 
         text = text.rstrip("\n") + "\n"
+        text = text.replace(DOUBLE_QUOTE_PLACEHOLDER, '"')
+        text = text.replace(SINGLE_QUOTE_PLACEHOLDER, "'")
 
         lines = text.splitlines(keepends=True)
         full_line_comments: list[tuple[int, str]] = []