Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data catalog] Fast follow: Fix indentation in CTAS #120

Closed
jeancochrane opened this issue Sep 11, 2023 · 0 comments · Fixed by #137
Closed

[Data catalog] Fast follow: Fix indentation in CTAS #120

jeancochrane opened this issue Sep 11, 2023 · 0 comments · Fixed by #137
Assignees
@jeancochrane
Milestone
Data catalog MVP

Comments

@jeancochrane
Copy link
Contributor

In #111, we added semantically unnecessary subqueries to the queries in aws-athena/ctas/ in order to make the diff easier to review. Once #111 comes in, we should remove these subqueries to keep the queries clean.

See this comment thread for context: https://github.com/ccao-data/data-architecture/pull/111/files#r1317607121

Blocked by #111.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeancochrane jeancochrane

Labels
None yet
Projects
None yet
Milestone
Data catalog MVP
Development

Successfully merging a pull request may close this issue.

Remove unnecessary subqueries in CTAS models ccao-data/data-architecture
1 participant
@jeancochrane