Remove unnecessary subqueries in CTAS models #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
changed the title
jeancochrane
changed the title
dfsnow
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Reviewing this with hidden whitespace makes the diff much less scary! Looks great @jeancochrane.
jeancochrane
deleted the
jeancochrane/120-data-catalog-fast-follow-fix-indentation-in-ctas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a simple change that produces an absolutely horrendous diff: Removing the semantically-unnecessary CTAS subqueries that we introduced to make the diff in #111 simpler. The goal was to keep this PR as simple as possible, changing nothing except formatting, so that the reviewer can skim the diff and be confident that they won't miss anything important.
The diff is much easier to read if you enable the "hide whitespace" feature in the
Files changedview:Closes #120.