Initialize data catalog overview docs with data flow diagram #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
force-pushed
the
jeancochrane/2-add-overall-architecture-diagram-for-the-data-dept
branch
from
45f09df
to
5c8c22b
Compare
jeancochrane
had a problem deploying
to
github-pages
GitHub Actions
Failure
jeancochrane
force-pushed
the
jeancochrane/2-add-overall-architecture-diagram-for-the-data-dept
branch
from
5c8c22b
to
8a86b51
Compare
jeancochrane
had a problem deploying
to
github-pages
GitHub Actions
Failure
jeancochrane
had a problem deploying
to
github-pages
GitHub Actions
Failure
jeancochrane
had a problem deploying
to
github-pages
GitHub Actions
Failure
jeancochrane
force-pushed
the
jeancochrane/2-add-overall-architecture-diagram-for-the-data-dept
branch
from
1f11baf
to
f770f49
Compare
jeancochrane
had a problem deploying
to
github-pages
GitHub Actions
Failure
jeancochrane
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jeancochrane
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This reverts commit 8a86b51.
jeancochrane
commented
Aug 29, 2023
dfsnow
requested changes
Aug 29, 2023
| - name: Prepare Mermaid assets for docs | ||
| run: | | ||
| for file in assets/*.mmd; do | ||
| mmdc -i "$file" -o "${file/.mmd/.png}" |
There was a problem hiding this comment.
nitpick (blocking): Can we swap the output file to SVG for better dark mode compatibility?
There was a problem hiding this comment.
Good call, done in 9caa3ea! The SVG is live on the production site if you want to spot check it.
jeancochrane
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Dan Snow <31494343+dfsnow@users.noreply.github.com>
…ges"" This reverts commit 0a22eaf.
jeancochrane
force-pushed
the
jeancochrane/2-add-overall-architecture-diagram-for-the-data-dept
branch
from
ec41767
to
46c91f7
Compare
jeancochrane
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…ent changes""" This reverts commit 46c91f7.
|
Should be ready for one more look @dfsnow! |
dfsnow
approved these changes
Aug 29, 2023
jeancochrane
deleted the
jeancochrane/2-add-overall-architecture-diagram-for-the-data-dept
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes the overview section of our dbt docs with a new data flow diagram for our department's data.
You can check out the diagram on the live docs site:
Closes ccao-data/wiki#2. Connects #67.