Do not fail cleanup-dbt-resources
workflow if databases do not exist
#105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
cleanup-dbt-resources
workflow that causes it to fail in the (expected) case where it attempts to clean up a database that has not been created by CI. We adjust the underlyingcleanup_dbt_resources.sh
script to continue execution in cases where theaws glue delete-database
command returns a nonzero status withEntityNotFoundException
in the output.Closes #104.
Local testing
I tested this PR locally since it would be a bit of a pain to test on CI. I tested two cases:
dev
target without building any models, and confirmed that it completed execution--asdf
flag to theaws glue delete-database
call, and confirmed that it stopped executionSelect a dropdown below to see the corresponding test output.
Sample output in the case of 404s
Sample output in the case of unexpected error