Fix default.vw_card_res_char
tests to better match the reality of the view
#110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Teams discussion with Nicole and Billy, I discovered two small problems with our
default.vw_card_res_char
tests:vw_card_res_char_unique_by_card_and_year
is incorrect, since this table is actually unique by card, year, and PINvw_card_res_char_renovation_fields_match
is not actually useful, since it's just checking derived data, and the logic that generates these data is much more complicated than a simple test like "char_renovation
should be the same value aschar_recent_renovation
"This PR adjusts these two tests to better reflect these properties of the underlying data, and to fix tests that are currently failing (example).
We also make one quick tweak to the command that runs dbt tests in the case of a cache hit, which allows us to properly run tests against upstream models.