Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbt docs with more detail on handling table models and upgrade to dbt 1.6 #136

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

jeancochrane
Copy link
Contributor

@jeancochrane jeancochrane commented Sep 15, 2023

The introduction of our spatial queries as materialized tables into the dbt DAG in #111 creates an additional layer of complexity for local dbt development, since the time to build the full DAG has increased from a couple of minutes to a couple of hours.

This PR updates the dbt README to provide detailed instructions on how to avoid building compute-intensive tables using dbt clone and the --exclude option. In order to support this workflow, we upgrade to the v1.6.x lines of dbt Core and the dbt-athena adapter, which are the first versions to support dbt clone in addition to being the latest stable minor versions of both libraries.

We also take this opportunity to sneak in one small improvement to developer experience by reducing the number of times that dbt-athena will retry a failed query from 5 to 1; in my experience, intermittent Athena failures are very rare compared to SQL syntax and compilation failures, and eliminating the retry logic allows for faster debugging cycles when trying to resolve the latter class of failure.

@jeancochrane jeancochrane force-pushed the jeancochrane/update-dbt-documentation branch from 9dea20e to 544c43e Compare September 15, 2023 17:00
@jeancochrane jeancochrane marked this pull request as ready for review September 15, 2023 17:05
@jeancochrane jeancochrane requested a review from a team as a code owner September 15, 2023 17:05
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jeancochrane! Very helpful addition.


```
dbt run --select location.vw_pin10_location default.vw_pin_universe
dbt clone --state master-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This is so cool! <3

Comment on lines +475 to +477
```
dbt run --select +model.vw_pin_shared_input --exclude location.* proximity.*
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely cool. Wild that dbt is this flexible.

@jeancochrane jeancochrane merged commit 8d89682 into master Sep 19, 2023
3 checks passed
@jeancochrane jeancochrane deleted the jeancochrane/update-dbt-documentation branch September 19, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants