Add shared / updated column documentation to default views #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
approved these changes
Oct 18, 2023
dfsnow
changed the title
|
@jeancochrane Can you review for implementation details + general overview of the columns? @wrridgeway Can you review for correctness of the column descriptions? I apologize in advance for the size of this PR. |
jeancochrane
approved these changes
Oct 24, 2023
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
wrridgeway
reviewed
Oct 25, 2023
| units of work and analysis for the Assessor's Office. Township boundaries are | ||
| coincident with triads (triads are made up of townships). Note that townships | ||
| can also be units of local government, with their own boards and taxing | ||
| authority. Townships in the City of Chicago are effectively vestigial |
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds column definitions/descriptions to almost every variable inside the
default.*views. It defines almost all the descriptions in a shared markdown file (shared_columns.md), since many of the views share the same fields.Upcoming PRs will:
shared_columns.md, where appropriateproximityandlocationviews