Fix cleanup-dbt-resources workflow to run on data-catalog branch #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
force-pushed
the
jeancochrane/fix-cleanup-dbt-resources-workflow
branch
from
a08431e
to
fb9a6c8
Compare
jeancochrane
commented
Aug 8, 2023
Comment on lines
+32
to
+33
| echo "CI context did not match any of the expected environments" | ||
| exit 1 |
There was a problem hiding this comment.
Not fully intentional, but the build ended up testing this path when I accidentally referenced GITHUB_REF_NAME instead of GITHUB_HEAD_REF for this run: https://github.com/ccao-data/data-architecture/actions/runs/5801770404/job/15726741689
dfsnow
approved these changes
Aug 8, 2023
| # GITHUB_HEAD_REF is only set on pull_request events, so if it's | ||
| # present, we must be in a PR context. Use the +x param expansion | ||
| # to distinguish empty strings: https://stackoverflow.com/a/13864829 | ||
| if [ ! -z ${GITHUB_HEAD_REF+x} ]; then |
There was a problem hiding this comment.
nitpick (non-blocking): Probably simpler to do: if [ -n "$GITHUB_HEAD_REF" ]; then
There was a problem hiding this comment.
Sure thing, done in 310645e! Why does bash have so many options for such a simple operation 🙃
jeancochrane
deleted the
jeancochrane/fix-cleanup-dbt-resources-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cleanup-dbt-resourcesworkflow is currently failing on thedata-catalogbranch becauseGITHUB_REF_NAMEappears to be set todata-catalogeven though the workflow is triggered from apull_requestevent:This PR adjusts the
configure-dbt-environmentaction to give higher priority to environments that haveGITHUB_HEAD_REFset when setting theHEAD_REFvariable for a pull request, since this variable is guaranteed to only be set onpull_requestevents, whereasGITHUB_REF_NAMEcan be set on bothpull_requestandpush(docs).