Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties that most impact each school district's property taxes #629

Merged
merged 15 commits into from
Oct 31, 2024
Merged

Properties that most impact each school district's property taxes #629

merged 15 commits into from
Oct 31, 2024

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Oct 24, 2024 •
edited
Loading

See #627

@wrridgeway wrridgeway self-assigned this Oct 24, 2024
@wrridgeway wrridgeway linked an issue Oct 24, 2024 that may be closed by this pull request
Assist: properties that most impact each school district's property taxes #627
Closed
13 tasks
@wrridgeway
Copy link
Member Author

@ccao-jardine I defined eav as

(pin.av_board - (
        pin.exe_homeowner
        + pin.exe_senior
        + pin.exe_freeze
        + pin.exe_longtime_homeowner
        + pin.exe_disabled
        + pin.exe_vet_returning
        + pin.exe_vet_dis_lt50
        + pin.exe_vet_dis_50_69
        + pin.exe_vet_dis_ge70
        + pin.exe_abate
    )) * fact.eq_factor_final

is that right? do we want to use av_clerk for things like ranking and eav rather than av_board?

ccao-jardine
ccao-jardine requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ccao-jardine ccao-jardine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change proposed for EAV calculation, thanks!

@wrridgeway wrridgeway marked this pull request as ready for review October 28, 2024 19:07
@wrridgeway wrridgeway requested a review from a team as a code owner October 28, 2024 19:07
@wrridgeway
Copy link
Member Author

Last Q - would you like board or clerk AV for rankings

@ccao-jardine
Copy link
Member

Last Q - would you like board or clerk AV for rankings

Let's do av_board, and @dfsnow can tell us the difference between av_board and av_clerk later 😅

@wrridgeway
Copy link
Member Author

wrridgeway commented Oct 31, 2024 •
edited
Loading

@ccao-jardine Good on your end? @jeancochrane You might need to review this as well.

ccao-jardine
ccao-jardine approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ccao-jardine ccao-jardine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎃

@wrridgeway wrridgeway merged commit c27bc8d into master Oct 31, 2024
8 checks passed
@wrridgeway wrridgeway deleted the 627-assist-properties-that-most-impact-each-school-districts-property-taxes branch October 31, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccao-jardine ccao-jardine ccao-jardine approved these changes

Assignees

@wrridgeway wrridgeway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assist: properties that most impact each school district's property taxes
2 participants
@wrridgeway @ccao-jardine