Add comment about manual cleaning to ccao-legacy.R script
#630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
deleted the
jeancochrane/add-comment-about-ownr-table-to-ccao-legacy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing exemption comparison work, I had to manually clean the file that represented an export of the
OWNRtable from the AS/400 to strip out some ASCII null characters that were being used instead of spaces (and thereby causingreader::read_fwf()to read the wrong column positions for those rows). This PR adds a single comment to theccao-legacy.Rscript that processes that export to note for posterity that the export has been manually edited.