Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row_id to default.vw_pin_universe #631

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

wrridgeway
Copy link
Member

This is a temporary addition to our pin universe view to allow us to push to the open data portal using socrata's API.

@wrridgeway wrridgeway marked this pull request as ready for review October 28, 2024 21:06
@wrridgeway wrridgeway requested a review from a team as a code owner October 28, 2024 21:06
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is it true that this identifier is temporary, as the PR body suggests? I assumed that we would need to keep this identifier going forward, even after the migration, but maybe my understanding was incorrect.

@@ -31,6 +31,7 @@ WITH pardat_adjusted_years AS (

SELECT
-- Main PIN-level attribute data from iasWorld
CONCAT(par.parid, par.taxyr) AS row_id,
Copy link
Contributor

@jeancochrane jeancochrane Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Thought, non-blocking] I wonder if it's worth making this identifier slightly more human-readable by including a delimiter between the component parts? I don't have a good sense of how important this will be down the road, or how easy it'll be to change going forward; if you feel strongly that it won't be important (i.e. no one will ever read this identifier) or it'll be easy to change going forward (i.e. we'll be able to easily add delimiters to the prod data at a future point if we choose), then feel free to ignore for now! Just something to think about as we look forward to migrating the rest of the views to use this system too.

Suggested change
CONCAT(par.parid, par.taxyr) AS row_id,
CONCAT(par.parid, '-', par.taxyr) AS row_id,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan was for this column to not even be visible on socrata. And since it won't exist long term in this view (generation will be done on the fly by the upload script) I'm not too worried about.

@wrridgeway wrridgeway merged commit 3334c9f into master Oct 29, 2024
7 checks passed
@wrridgeway wrridgeway deleted the add-rowid-to-pin-universe branch October 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants