-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all aggregate land calculations with pulls from agg land view #77
Replace all aggregate land calculations with pulls from agg land view #77
Conversation
…all-views-with-defaultvw_pin_land
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wrridgeway I'm seeing some differences between the original aggregate_land
CTE total row count and the new default.vw_pin_land
total row count. Here's an example:
SELECT COUNT(*)
FROM "default"."vw_pin_land"
WHERE year = '2022';
Row count: 1,864,776
SELECT COUNT(*)
FROM (
SELECT parid
FROM "iasworld"."land"
WHERE taxyr = '2022'
AND land.cur = 'Y'
AND land.deactivat IS NULL
GROUP BY parid, taxyr
)
Row count: 1,864,932
Can you look into the difference between these two?
Good catch. Should be sorted now, can't use lline = 1 since that row can be deactivated in some cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Looks good now @wrridgeway. I'll go ahead and merge this.
Aggregating land square footage needs to incorporate the
influ
column iniasworld.land
and some land line heuristics, rather than just summing by parcel.We need to make sure every view that aggregates land sf uses this new view for consistency and accuracy.