Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dbt production deploy problems #82

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Fix dbt production deploy problems #82

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83a44a
Use rsync instead of mv to update dbt cache dir in CI
jeancochrane Aug 18, 2023
64fcdf2
Make sure to configure dbt env vars before generating docs in deploy-…
jeancochrane Aug 18, 2023
068ddad
Better caching to support restore-keys flow in build_and_test_dbt wor…
jeancochrane Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_dbt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@ jobs:
shell: bash

- name: Move dbt manifest directory to update cache
run: mv "$TARGET_DIR" "$STATE_DIR"
run: rsync -av --delete "$TARGET_DIR/" "$STATE_DIR"
working-directory: ${{ env.PROJECT_DIR }}
shell: bash
3 changes: 3 additions & 0 deletions .github/workflows/deploy_dbt_docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
role-to-assume: ${{ secrets.AWS_IAM_ROLE_TO_ASSUME_ARN }}
aws-region: us-east-1

- name: Configure dbt environment
uses: ./.github/actions/configure_dbt_environment
Comment on lines +34 to +35
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error in question:

Run dbt docs generate --target "$TARGET"
18:26:[23](https://github.com/ccao-data/data-architecture/actions/runs/5905883640/job/16020814093#step:6:24)  Running with dbt=1.5.5
18:[26](https://github.com/ccao-data/data-architecture/actions/runs/5905883640/job/16020814093#step:6:27):23  Encountered an error:
Runtime Error
  The profile 'athena' does not have a target named ''. The valid target names for this profile are:
   - dev
   - ci
   - prod
Error: Process completed with exit code 2.

Previously we had been hardcoding the target "ci" so I hadn't noticed that we were missing this step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I should've caught this too. Tricky tricky


- name: Generate docs
run: dbt docs generate --target "$TARGET"
working-directory: ${{ env.PROJECT_DIR }}
Expand Down