Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy environment config to deploy_dbt_docs workflow #94

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

jeancochrane
Copy link
Contributor

@jeancochrane jeancochrane commented Aug 24, 2023

Dan noticed that the Deployments view for this repo isn't showing any successful docs deployments to GitHub Pages, despite the fact that we can see successful runs for the deploy-dbt-docs workflow. Comparing this repo to assesspy, I noticed that we're missing an environment attribute in the deploy-dbt-docs workflow, which I suspect is the culprit.

    environment:
      name: github-pages
      url: ${{ steps.deployment.outputs.page_url }}

This PR adds an environment attribute to the deploy-dbt-docs workflow in order to get our Deployments view to show the correct status of our Pages deployments.

In order to test this change, I temporarily updated the deployment workflow to deploy from this PR in 59a994c. While the deployment failed due to environment branch protection rules, you can confirm in the Deployments view that we did in fact attempt a deployment from this commit.

@jeancochrane jeancochrane marked this pull request as ready for review August 24, 2023 16:51
@jeancochrane jeancochrane requested a review from a team as a code owner August 24, 2023 16:51
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix! Thanks for taking care of this.

@jeancochrane jeancochrane merged commit 2c2f583 into master Aug 24, 2023
3 checks passed
@jeancochrane jeancochrane deleted the jeancochrane/add-deploy-environment branch August 24, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants