Add deploy environment config to deploy_dbt_docs workflow #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dan noticed that the Deployments view for this repo isn't showing any successful docs deployments to GitHub Pages, despite the fact that we can see successful runs for the
deploy-dbt-docs
workflow. Comparing this repo to assesspy, I noticed that we're missing anenvironment
attribute in thedeploy-dbt-docs
workflow, which I suspect is the culprit.This PR adds an
environment
attribute to thedeploy-dbt-docs
workflow in order to get our Deployments view to show the correct status of our Pages deployments.In order to test this change, I temporarily updated the deployment workflow to deploy from this PR in 59a994c. While the deployment failed due to environment branch protection rules, you can confirm in the Deployments view that we did in fact attempt a deployment from this commit.