Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Pin build-and-run-batch-job workflow ref to main #11

Merged

Conversation

jeancochrane
Copy link
Contributor

@jeancochrane jeancochrane commented Nov 14, 2023

Merging #9 revealed a bug in the build-and-run-model.yaml workflow: When calling a reusable workflow from an external repository, the ref for the workflow always needs to be defined in the uses: attribute (SO source) (example failed run).

For evidence that this works, note that the build step successfully loaded and ran in this workflow run: https://github.com/ccao-data/model-condo-avm/actions/runs/6870496545/job/18685510675?pr=11

@jeancochrane
Copy link
Contributor Author

I'm going to wait to merge this until ccao-data/actions#3 comes in, since that PR will help with the cleanup for this PR.

@jeancochrane jeancochrane merged commit 57ef75b into master Nov 15, 2023
3 of 4 checks passed
@jeancochrane jeancochrane deleted the jeancochrane/bugfix-pin-batch-workflow-to-main-branch branch November 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants