Skip to content

Commit

Permalink
Clean up deployment-design.md
Browse files Browse the repository at this point in the history
  • Loading branch information
jeancochrane authored Oct 18, 2023
1 parent 5cfc7ca commit 16665fc
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions docs/deployment-design.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ Here is a rough sketch of a new model deployment pipeline:
* Use the AWS CLI to [submit a job](https://docs.aws.amazon.com/cli/latest/reference/batch/submit-job.html) to the Batch queue
* Use the AWS CLI to [poll the job status](https://awscli.amazonaws.com/v2/documentation/api/latest/reference/batch/describe-jobs.html) until it has a terminal status (`SUCCEEDED` or `FAILED`)
* Once the job has at least a `RUNNING` status, use the `jobStreamName` parameter to print a link to its logs
* _TK: Output?_
* _TK: How should we format output for pushing back to the PR? Is it enough to push the results doc to S3 and print a link in the workflow output, or do we need an integration that can actually post a comment on the PR, à la Codecov?_

## Tasks

We will create GitHub issues for the following tasks:

* Add Docker image definition for the model
* Add GitHub workflow to deploy and run an AWS Batch job on commits to PRs
* _TK: Show better output?_
* _TK: Output reporting improvements?_

0 comments on commit 16665fc

Please sign in to comment.