Edit DVC deps to include cmd run files #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnerlmichael
changed the title
wagnerlmichael
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
dfsnow
requested changes
May 13, 2024
There was a problem hiding this comment.
@wagnerlmichael Thanks for grabbing this. Can you run the pipeline or md5 hash the files manually and add them to the dvc.lock file? Then repeat this same PR for the condo model.
…-include-files-invoked-as-deps Merge master in
…-dvcyaml-to-include-files-invoked-as-deps Merge in sales val spec change branch
dfsnow
reviewed
Aug 14, 2024
There was a problem hiding this comment.
@wagnerlmichael Same thing here. Can you just make sure that merging master didn't change any of the hashes?
(venv) miwagne@ccao-datals:~/repos/model-res-avm/pipeline$ find . -type f -maxdepth 1 -exec md5sum {} +
c04f9224e873b1ee29a64fa68aa6c8d9 ./00-ingest.R
5e8c9b7d547ea41d9ec9441465e6e275 ./02-assess.R
d33c8e642e5e29a0683463ce885771f8 ./03-evaluate.R
b4615315b52165eed4a030c94def015b ./07-export.R
3b7d11c518447cf6c14ec7668c488968 ./06-upload.R
67b83129bec4027ac9e321a041c14c58 ./08-api.R
1cc57c0bcdaf2725fa343c6d88c1592c ./04-interpret.R
5c5a5100ebae2013bc24e8f9333d136b ./05-finalize.R
46115d48cf066d35b0db14dc13a8d9b3 ./01-train.R@dfsnow I git pulled and they match up |
dfsnow
approved these changes
Aug 17, 2024
wagnerlmichael
deleted the
239-edit-dvcyaml-to-include-files-invoked-as-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR edits the
dvc.yamlfile's deps to be consistent with the documentation by adding the files invoked as deps.