Add leaflet maps to new_feature_template #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
Damonamajor
commented
Aug 6, 2024
|
|
||
| create_leaflet_map(largest_fmv_decreases, "diff_pred_pin_initial_fmv", "Largest FMV Decreases (%)", order_scheme = "low") | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We have a bunch of FMV increases. We should probably only have a couple, but just let me know which ones you think are best to keep. There are some pretty large swings due to the multicard heuristics, which we may or may not want to track.
Damonamajor
commented
Aug 7, 2024
| } | ||
| ``` | ||
|
|
||
| ## Highest and Lowest 100 Values |
There was a problem hiding this comment.
This is the only map which doesn't work with categorical, and I don't see a readily comparable option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the unwanted leaflet maps, as well as modifying the code to render a list of SHAP values for each pin, rather than plotting on a card level
#250