Refactor model workflow to use external workflow defined in ccao-data/actions
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
2 times, most recently
from
950e448
to
953219f
Compare
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
953219f
to
9392c55
Compare
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
cc52be7
to
e04d52e
Compare
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
e04d52e
to
86729e1
Compare
…b-deploy workflow
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
d125b08
to
5030512
Compare
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
5030512
to
e3320d7
Compare
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
e3320d7
to
d61e064
Compare
jeancochrane
commented
Nov 9, 2023
| name: build-and-run-model | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, closed] |
There was a problem hiding this comment.
Per the docs, opened, reopened, and closed are the default enabled event types when pull_request is enabled without a types attribute (as was the case before this PR). Now that the build-and-run-batch-job workflow supports running a cleanup step on the closed event (see docs here), we need to specify all of the previously-implicit event types in order to add closed to the list.
| @@ -26,12 +27,11 @@ jobs: | |||
| # required in order to allow the reusable called workflow to push to | |||
| # GitHub Container Registry | |||
| packages: write | |||
| uses: ./.github/workflows/build-and-run-batch-job.yaml | |||
| uses: ccao-data/actions/.github/workflows/build-and-run-batch-job.yaml@master | |||
There was a problem hiding this comment.
While it would be better to pin to a specific release of ccao-data/actions, my thinking is that it makes sense to pin to master while we're iterating quickly, and then pin to a tag once things are feeling stable.
Alternatively, we could pin to a specific commit SHA instead, but we won't know what that SHA is until ccao-data/actions#1 gets merged.
jeancochrane
changed the title
ccao-data/actions workflowsccao-data/actions
jeancochrane
force-pushed
the
jeancochrane/switch-to-external-actions-and-workflows
branch
from
a2b242c
to
568b8aa
Compare
dfsnow
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
@jeancochrane This is absolutely awesome! Super clean implementation. I can't wait to really test it out with some runs.
jeancochrane
had a problem deploying
to
deploy
GitHub Actions
Failure
jeancochrane
deleted the
jeancochrane/switch-to-external-actions-and-workflows
branch
This was referenced Nov 14, 2023
jeancochrane
added a commit
that referenced
this pull request
Sep 20, 2024
jeancochrane
added a commit
that referenced
this pull request
Sep 26, 2024
* Pin build-and-run-batch-job to branch that fixes Terraform configs * Delete terraform directory that has been unused since #59 * Lower resource requirements in build-and-run-model to test changing job definition * Add missing ref, which is necessary when testing a different branch of ccao-data/actions * Switch build-and-run-model params back to their usual values after testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
build-and-run-modelworkflow to point to the reusablebuild-and-run-batch-jobworkflow defined in ccao-data/actions#1. In the process, it removes a number of extraneous files that are now being managed by the external workflow:setup-terraformactionpoll_batch_job_script.shscriptcleanup-modelandcleanup-terraformworkflows, which are now included as part of thecleanupstep inbuild-and-run-batch-job.Connects ccao-data/model-condo-avm#5.
Testing
buildandtestjobs of thebuild-and-run-modelworkflow, see this workflow runrunjob fails, but only because I terminated the Batch job before it would complete; once the workflow gets to the point where it's polling the status of the Batch job, we can be confident that the test has passed, since nothing in the model pipeline itself has changed in this PRcleanupjob of thebuild-and-run-modelworkflow, see this workflow run