Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gates and definitions up to dimension 7 #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KevinMTO
Copy link
Collaborator

added gates and definitions up to dimension 7

Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 10 concern(s)
  • include/dd/GateMatrixDefinitions.hpp:291:13: warning: [modernize-use-auto]

    use auto when initializing with a cast to avoid duplicating the type name

                dd::ComplexValue omega    = dd::ComplexValue{cos(omegaArg * PI), sin(omegaArg * PI)};
                ^~~~~~~~~~~~~~~~
                auto
  • include/dd/GateMatrixDefinitions.hpp:456:13: warning: [modernize-use-auto]

    use auto when initializing with a cast to avoid duplicating the type name

                dd::ComplexValue omega    = dd::ComplexValue{std::cos(omegaArg * PI), std::sin(omegaArg * PI)};
                ^~~~~~~~~~~~~~~~
                auto
  • include/dd/GateMatrixDefinitions.hpp:673:13: warning: [modernize-use-auto]

    use auto when initializing with a cast to avoid duplicating the type name

                dd::ComplexValue omega    = dd::ComplexValue{std::cos(omegaArg * PI), std::sin(omegaArg * PI)};
                ^~~~~~~~~~~~~~~~
                auto
  • include/dd/GateMatrixDefinitions.hpp:881:13: warning: [modernize-use-auto]

    use auto when initializing with a cast to avoid duplicating the type name

                dd::ComplexValue omega    = dd::ComplexValue{std::cos(omegaArg * PI), std::sin(omegaArg * PI)};
                ^~~~~~~~~~~~~~~~
                auto
  • include/dd/GateMatrixDefinitions.hpp:1084:13: warning: [modernize-use-auto]

    use auto when initializing with a cast to avoid duplicating the type name

                dd::ComplexValue omega    = dd::ComplexValue{std::cos(omegaArg * PI), std::sin(omegaArg * PI)};
                ^~~~~~~~~~~~~~~~
                auto
  • include/dd/MDDPackage.hpp:504:30: warning: [clang-diagnostic-unused-variable]

    unused variable 'cc'

                for (const auto& cc: controls) {
                                 ^
  • include/dd/MDDPackage.hpp:1205:15: warning: [readability-identifier-naming]

    invalid case style for method 'CEX'

            mEdge CEX(QuantumRegisterCount numberRegs, dd::Control::Type level,
                  ^~~
                  cex
  • include/dd/MDDPackage.hpp:1217:15: warning: [readability-else-after-return]

    do not use 'else' after 'return'

                } else if (registersSizes.at(static_cast<std::size_t>(target)) == 3) {
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • include/dd/MDDPackage.hpp:1257:15: warning: [readability-identifier-naming]

    invalid case style for method 'CSUM'

            mEdge CSUM(QuantumRegisterCount numberRegs, QuantumRegister cReg, QuantumRegister target, bool isDagger = false) {
                  ^~~~
                  csum
  • include/dd/MDDPackage.hpp:1275:15: warning: [readability-else-after-return]

    do not use 'else' after 'return'

                } else if (registersSizes.at(static_cast<std::size_t>(target)) == 3) {
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 42.37288% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 67.0%. Comparing base (f775b69) to head (7e2eafb).

Files Patch % Lines
include/dd/MDDPackage.hpp 42.5% 31 Missing ⚠️
include/dd/GateMatrixDefinitions.hpp 40.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #21     +/-   ##
=======================================
- Coverage   67.2%   67.0%   -0.3%     
=======================================
  Files         16      16             
  Lines       2270    2239     -31     
  Branches     377     381      +4     
=======================================
- Hits        1527    1501     -26     
+ Misses       743     738      -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant