Skip to content

internal updates #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
+6 −1
Closed

internal updates #2228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions checker/standard_library.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,9 @@ absl::Status AddTimeFunctions(TypeCheckerBuilder& builder) {
get_seconds.set_name(StandardFunctions::kSeconds);
CEL_RETURN_IF_ERROR(get_seconds.AddOverload(MakeMemberOverloadDecl(
StandardOverloadIds::kTimestampToSeconds, IntType(), TimestampType())));
CEL_RETURN_IF_ERROR(get_seconds.AddOverload(
MakeMemberOverloadDecl(StandardOverloadIds::kTimestampToSecondsTz,
IntType(), TimestampType(), StringType())));
CEL_RETURN_IF_ERROR(get_seconds.AddOverload(
MakeMemberOverloadDecl(StandardOverloadIds::kTimestampToSecondsWithTz,
IntType(), TimestampType(), StringType())));
Expand Down
4 changes: 3 additions & 1 deletion common/standard_definitions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ struct StandardOverloadIds {
static constexpr absl::string_view kDurationToMinutes = "duration_to_minutes";
static constexpr absl::string_view kTimestampToSeconds =
"timestamp_to_seconds";
static constexpr absl::string_view kTimestampToSecondsWithTz =
static constexpr absl::string_view kTimestampToSecondsTz =
"timestamp_to_seconds_tz";
static constexpr absl::string_view kTimestampToSecondsWithTz =
"timestamp_to_seconds_with_tz";
static constexpr absl::string_view kDurationToSeconds = "duration_to_seconds";
static constexpr absl::string_view kTimestampToMilliseconds =
"timestamp_to_milliseconds";
Expand Down
Loading