update behavior of app.result_expires to match celery docs #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Celery documentation indicates that app.result_expires of CELERY_RESULT_EXPIRES should respect values of 0 or None: "A value of None or 0 means results will never expire (depending on backend specifications)."
auvipy
requested changes
Jul 24, 2023
| @@ -194,6 +194,8 @@ def _forget(self, task_id): | |||
|
|
|||
| def cleanup(self): | |||
| """Delete expired metadata.""" | |||
| if not self.expires: | |||
There was a problem hiding this comment.
i would love to see unit test for this
There was a problem hiding this comment.
This function is not covered in current unit tests, I didn't consider it the responsibility of this PR to add missing coverage. However, I can add a unit test.
There was a problem hiding this comment.
you can add a basic unit test for this added change or that function as you like
There was a problem hiding this comment.
it would be helpful if you can add a basic unit test so we can merge with confidence
auvipy
reviewed
Feb 6, 2024
|
Any updates on this? |
we need either automated test, or manual acknowledgment for the proposed change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celery documentation indicates that app.result_expires (or CELERY_RESULT_EXPIRES) should respect values of 0 or None: "A value of None or 0 means results will never expire (depending on backend specifications)."