Fix mongodb connection parameters not passed correctly #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
May 15, 2022
| @@ -313,6 +313,7 @@ def _parse_uri(self, scheme='mongodb://'): | |||
| if self.connect_timeout else None), | |||
| } | |||
| options.update(parsed['options']) | |||
| options.update(client.transport_options) | |||
There was a problem hiding this comment.
can you please add test for the proposed change?
There was a problem hiding this comment.
can you address the tests please?
|
also integration tests are failing |
auvipy
requested changes
Oct 19, 2022
| @@ -313,6 +313,7 @@ def _parse_uri(self, scheme='mongodb://'): | |||
| if self.connect_timeout else None), | |||
| } | |||
| options.update(parsed['options']) | |||
| options.update(client.transport_options) | |||
There was a problem hiding this comment.
can you address the tests please?
thedrow
requested changes
Dec 26, 2022
|
@auvipy Hi, Are there any documents about unit tests I can refer to? |
you can found existing tests here https://github.com/celery/kombu/blob/main/t/unit/transport/test_mongodb.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kombu 3.x versions, the MongoDB transport allows accepting the Celery
transport_optionsparameters(BROKER_TRANSPORT_OPTIONS) as connection parameters.In #537 , removed support for parameter passing, maybe we should add it back.