Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpcio to 1.67.0 #2156

Closed
wants to merge 1 commit into from
Closed

Conversation

pyup-bot
Copy link
Collaborator

This PR updates grpcio from 1.66.2 to 1.67.0.

The bot wasn't able to find a changelog for this release. Got an idea?

Links

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (1691d3e) to head (62be667).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2156   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          77       77           
  Lines        9500     9500           
  Branches     1148     1148           
=======================================
  Hits         7740     7740           
  Misses       1569     1569           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nusnus
Nusnus previously approved these changes Oct 16, 2024
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.13 support was added to this dep :)

@Nusnus Nusnus dismissed their stale review October 16, 2024 11:02

Dismissing my review until the CI fully passes

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs to fully pass

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately pypy is broken with this new version so we can’t merge.

@haimjether
Copy link
Contributor

In order for this to work, it takes manually building and to pushing grpcio 1.67.0 pypy version to https://celery.github.io/celery-wheelhouse/repo/simple/ the same way
celery/celery-wheelhouse#4 did

@haimjether
Copy link
Contributor

Update: Added a PR for this, just in case: celery/celery-wheelhouse#5

@Nusnus
Copy link
Member

Nusnus commented Oct 17, 2024

Update: Added a PR for this, just in case: celery/celery-wheelhouse#5

This fixed it!
Thanks!

I merged #2158 instead as I like dependabot’s rich description better.

@Nusnus Nusnus closed this Oct 17, 2024
@Nusnus Nusnus deleted the pyup-update-grpcio-1.66.2-to-1.67.0 branch October 17, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants