Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: restrict google-cloud-pubsub version #2160

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

haimjether
Copy link
Contributor

  • google-cloud-pubsub version in versions larger than 2.20.3 raises the following error:

site-packages/google/protobuf/internal/well_known_types.py", line 443, in FromTimedelta
raise AttributeError(
AttributeError: Fail to convert to Duration.
Expected a timedelta like object got str: 'str' object has no attribute 'seconds'

Fix this by restriction of the allowed package versions.

@haimjether haimjether force-pushed the haim/fix/restrict_pubsub_version branch from 1814bb6 to 179af94 Compare October 17, 2024 09:20
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (6a1e43c) to head (f26b2fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
- Coverage   81.47%   81.45%   -0.03%     
==========================================
  Files          77       77              
  Lines        9500     9500              
  Branches     1148     1049      -99     
==========================================
- Hits         7740     7738       -2     
- Misses       1569     1570       +1     
- Partials      191      192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haimjether haimjether marked this pull request as ready for review October 17, 2024 09:28
- google-cloud-pubsub version in versions larger than 2.20.3 raises the following error:

site-packages/google/protobuf/internal/well_known_types.py", line 443, in FromTimedelta
    raise AttributeError(
AttributeError: Fail to convert to Duration.
Expected a timedelta like object got str: 'str' object has no attribute 'seconds'

  Fix this by restriction of the allowed package versions.
@Nusnus Nusnus force-pushed the haim/fix/restrict_pubsub_version branch from 179af94 to f26b2fb Compare October 17, 2024 11:34
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Nusnus Nusnus merged commit 6a77355 into celery:main Oct 17, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants