-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression from #2148 #2165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
+ Coverage 81.47% 81.48% +0.01%
==========================================
Files 77 77
Lines 9500 9507 +7
Branches 1148 1148
==========================================
+ Hits 7740 7747 +7
Misses 1569 1569
Partials 191 191 ☔ View full report in Codecov by Sentry. |
@auvipy Please note @thedrow asked for my review so please wait for me too next time bro 😉 Anyways, @thedrow , the changes indeed look fine, but did you test it with Celery with this transport (manually, once at least)? I mean reproducing exactly the same flow as @woutdenolf did in the report |
oh damn! sorry! will wait for you from the next time. |
Take it easy my friend, I just want to make sure we have the best code possible so it's important to unite and work as a team. Next time we'll all improve 🚀 |
Yes I did. It works. |
Awesome!! |
Fixes #2157.