Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression from #2148 #2165

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix regression from #2148 #2165

merged 2 commits into from
Oct 21, 2024

Conversation

thedrow
Copy link
Member

@thedrow thedrow commented Oct 20, 2024

Fixes #2157.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (6a77355) to head (1e09964).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2165      +/-   ##
==========================================
+ Coverage   81.47%   81.48%   +0.01%     
==========================================
  Files          77       77              
  Lines        9500     9507       +7     
  Branches     1148     1148              
==========================================
+ Hits         7740     7747       +7     
  Misses       1569     1569              
  Partials      191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy merged commit 7e4f1bb into celery:main Oct 21, 2024
37 checks passed
@Nusnus
Copy link
Member

Nusnus commented Oct 21, 2024

@auvipy Please note @thedrow asked for my review so please wait for me too next time bro 😉
I'm trying to help him refine the code so we can move fast and complete the releases.

Anyways, @thedrow , the changes indeed look fine, but did you test it with Celery with this transport (manually, once at least)? I mean reproducing exactly the same flow as @woutdenolf did in the report

@auvipy
Copy link
Member

auvipy commented Oct 21, 2024

oh damn! sorry! will wait for you from the next time.

@Nusnus
Copy link
Member

Nusnus commented Oct 21, 2024

oh damn! sorry! will wait for you from the next time.

Take it easy my friend, I just want to make sure we have the best code possible so it's important to unite and work as a team. Next time we'll all improve 🚀

@thedrow
Copy link
Member Author

thedrow commented Oct 21, 2024

Yes I did. It works.

@Nusnus
Copy link
Member

Nusnus commented Oct 21, 2024

Yes I did. It works.

Awesome!!
Thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 5.5.0rc1: sqlalchemy create_engine issue
3 participants