Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CD: .github/workflows/deploy.yml #104

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Dec 7, 2023

No description provided.

@Nusnus Nusnus self-assigned this Dec 7, 2023
@Nusnus Nusnus marked this pull request as ready for review December 7, 2023 18:29
@Nusnus Nusnus merged commit af9993b into celery:main Dec 7, 2023
4 of 6 checks passed
@Nusnus
Copy link
Member Author

Nusnus commented Dec 7, 2023

Woohoo 🥳
We have full CI/CD in pytest-celery.
A release to GitHub is all that is required (even less - just a version tag).

@auvipy I'll explain it all on our zoom meeting, but I am just so happy it worked on the first attempt!
TL;DR for releasing a version:

  1. Run poetry version 1.2.3 locally -> commit with 'Bump version: 1.2.3 → 4.5.6'" -> Open PR to main.
  2. Once CI is fully passing on the PR -> Merge.
  3. Release on github from main with new version tag -> automatically publishes to PyPI.

This gives a double check on the CI in the bump version PR making sure everything is alright before release, also allows adding changelog to this PR and having a single PR for all of the release work. Then, an automatically generated release with a new tag takes care of the CD, and no funny games - it just works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant