Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for dynamic worker args #203

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Feb 13, 2024

Added default_worker_command fixture to allow configuring the worker’s cmdline without touching the docker stuff.
Added test shows example for changing the —pool configuration.

Requires adding command=fxtr("default_worker_command”) to all default worker containers overrides, everywhere!

@Nusnus Nusnus added the feature Feature request label Feb 13, 2024
@Nusnus Nusnus added this to the v1.0.0b3 milestone Feb 13, 2024
@Nusnus Nusnus self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5b5ca39) 28.36% compared to head (ef975d1) 28.01%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/pytest_celery/vendors/worker/container.py 0.00% 4 Missing ⚠️
...rc/pytest_celery/vendors/redis/backend/fixtures.py 0.00% 3 Missing ⚠️
src/pytest_celery/vendors/redis/broker/fixtures.py 0.00% 3 Missing ⚠️
src/pytest_celery/vendors/worker/fixtures.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   28.36%   28.01%   -0.36%     
==========================================
  Files          36       36              
  Lines        1040     1053      +13     
  Branches      209      213       +4     
==========================================
  Hits          295      295              
- Misses        717      730      +13     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus
Copy link
Member Author

Nusnus commented Feb 13, 2024

Examples are expected to break as they install pytest-celery from main

@Nusnus Nusnus marked this pull request as ready for review February 13, 2024 20:42
@Nusnus Nusnus merged commit f791921 into celery:main Feb 13, 2024
26 of 31 checks passed
@Nusnus Nusnus deleted the feature branch February 13, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant