Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerated celery test setup boot #66

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Oct 15, 2023

No description provided.

@Nusnus Nusnus self-assigned this Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (01aafda) 23.06% compared to head (29a793d) 22.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   23.06%   22.46%   -0.61%     
==========================================
  Files          34       34              
  Lines         880      886       +6     
  Branches      170      174       +4     
==========================================
- Hits          203      199       -4     
- Misses        660      671      +11     
+ Partials       17       16       -1     
Files Coverage Δ
src/pytest_celery/fixtures/setup.py 29.16% <ø> (-2.84%) ⬇️
src/pytest_celery/api/setup.py 21.59% <0.00%> (-5.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus marked this pull request as ready for review October 15, 2023 16:46
@Nusnus Nusnus merged commit 709a59a into celery:main Oct 15, 2023
20 of 23 checks passed
@auvipy
Copy link
Member

auvipy commented Oct 16, 2023

I have a humble request here. since you are doing lots of heavy lifting here for rewriting this library or introducing new mechanisms/goodies, it would be great to add some basic descriptions/context so that other interested maintainers or contributor can understand what was being done any why. brief summary would be great enough. this way we will have more people understanding the package in future, in case something bad happen to you people. [god forbid]

@Nusnus
Copy link
Member Author

Nusnus commented Oct 16, 2023

I have a humble request here. since you are doing lots of heavy lifting here for rewriting this library or introducing new mechanisms/goodies, it would be great to add some basic descriptions/context so that other interested maintainers or contributor can understand what was being done any why. brief summary would be great enough. this way we will have more people understanding the package in future, in case something bad happen to you people. [god forbid]

I have committed myself to complete this task no matter what my friend. Thank you for worrying about my situation, but I assure you I'll get the job done, which includes finishing the heavy lifting I'm doing these days but also a full and complete documentation.

I'm keeping myself as safe as possible, but in case something happens, I assure you the code quality is high enough for someone else to take it forward.

P.S
The lib is practically done, only left adding tests coverage & implementing additional APIs to the existing objects per the tests I am developing in the celery/celery#8241 PR. Once I finish adding a few more smoke tests I'll start the documentation & alpha/beta/rc/release v1.0.0.

@auvipy ❤️🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants