Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling broker/backend for worker #89

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Nov 27, 2023

No description provided.

@Nusnus Nusnus self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (371d537) 23.74% compared to head (111b066) 24.86%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/pytest_celery/api/setup.py 73.91% 0 Missing and 6 partials ⚠️
src/pytest_celery/fixtures/backend.py 33.33% 2 Missing ⚠️
src/pytest_celery/fixtures/broker.py 33.33% 2 Missing ⚠️
src/pytest_celery/vendors/worker/container.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   23.74%   24.86%   +1.12%     
==========================================
  Files          34       34              
  Lines         939      957      +18     
  Branches      182      190       +8     
==========================================
+ Hits          223      238      +15     
+ Misses        694      693       -1     
- Partials       22       26       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus
Copy link
Member Author

Nusnus commented Nov 28, 2023

Type annotation was using syntax that wasn't supported in < Python 3.10.
Fixed now.

@Nusnus Nusnus force-pushed the allow_disabling_clusters branch 4 times, most recently from 088de86 to a04cabc Compare November 28, 2023 18:04
@Nusnus
Copy link
Member Author

Nusnus commented Nov 28, 2023

Added automatic tests

…celery_broker_cluster, celery_backend_cluster
@Nusnus Nusnus marked this pull request as ready for review November 28, 2023 18:48
@Nusnus Nusnus merged commit 332b980 into celery:main Nov 28, 2023
26 checks passed
@Nusnus Nusnus deleted the allow_disabling_clusters branch November 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant