Fix smart contracts release process docs - #2139
Conversation
…move deprecated networks
|
Picked this up while triaging the open queue. The fixes are real and still needed — I verified the two external claims:
The problem is the base, not the change. This branch is from February and main has moved past it in four places, so merging as-is would revert them:
The Baklava/Alfajores → Celo Sepolia edits are also already on main via #2175. And if you rebase this branch you get a real defect that is not in either version: T+2w and T+3w both end up saying "deploy the contracts to Celo Sepolia", because the old two-testnet ladder collapses onto a table main has already restructured correctly. Rather than ask you to untangle a six-month-old rebase, I opened #2295 with only the parts main still needs, on current main, with you as co-author. It also makes each bash block self-contained (six of them referenced @martinvol — one thing I could not verify and would like your eyes on: the flag and generated-filename changes ( Suggest closing this in favour of #2295 once you are happy with it. |
|
Closing in favour of #2295, which carries this work rebuilt on current main with you as co-author. To be clear about what is being closed: the bugs you found were real and are all fixed in #2295. Verified against celo-org/celo-monorepo before porting them:
What could not be salvaged was the base. Opened in February, main has moved past it in four places, so merging as-is would have reverted them: the #2295 additionally makes each bash block self-contained: six of them referenced @martinvol — the one part I took on trust and would like you to check on #2295 is the flag and generated-filename set ( |
Summary
-rand-pdeprecated, libraries file renamed)${N-1}→$((N-1))for arithmetic, remove MDXexport const Nworkaroundpackages/what-is-celo/about-celo-l1/protocol/releaseData/→packages/protocol/releaseData/.circleci/config.ymlreferences to.github/workflows/celo-monorepo.yml