Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 dev compatibile #407

Merged
merged 40 commits into from
Feb 9, 2022
Merged

4.0.0 dev compatibile #407

merged 40 commits into from
Feb 9, 2022

Conversation

KarishmaBothara
Copy link
Contributor

@KarishmaBothara KarishmaBothara commented Dec 24, 2021

With this PR,

  1. Api is updated with current latest polkadot-version 7.6.1,
  2. Updated types and test for nft as per (https://github.com/cennznet/cennznet/pull/535/files)
  3. Now polkadots 7.x typegen script requires endpoint
    generate:defs": "ts-node --skip-project node_modules/.bin/polkadot-types-from-defs --package @cennznet/types/interfaces --endpoint ./cennznet.json --input ./src/interfaces" (7.x typegen configuration (migration from 5.1.1) polkadot-js/api#4481)
  4. Updated staking derive module to stakingCennznet cause as per new polkadot version https://github.com/polkadot-js/api/blob/master/packages/api-derive/src/bundle.ts#L67
    https://github.com/polkadot-js/api/blob/master/packages/api-derive/src/bundle.ts#L23 (enable derive only if erasRewardPoints exist
  5. Updated WithdrawReasons to Reasons for BalanceLock

@KarishmaBothara KarishmaBothara changed the base branch from master to develop December 24, 2021 04:40
@KarishmaBothara
Copy link
Contributor Author

KarishmaBothara commented Feb 4, 2022

Things to do

  1. Unskip tests related to custom/slim metadata (needs some investigation - (FATAL: Unable to initialize the API: createType(Lookup111):: PortableRegistry: Unable to find type with lookupId Lookup111)
  2. Unskip Governance test
  3. Bring in changes related to Eth-bridge from master to develop branch and test

Copy link
Contributor

@ken-futureverse ken-futureverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarishmaBothara can't say that I fully understand this PR but I reckon it's good to merge and release the next alpha version to try it out.

@KarishmaBothara
Copy link
Contributor Author

Tests related to custom/slim metadata are all working
Eth-bridge stuff is added to this branch

Copy link
Contributor

@jordy25519 jordy25519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general.
few commented code lines to tidy up
can you take note (for release notes/upgrade guide) of the breaking changes e.g. api.derive.staking => api.derive.cennzStaking, are users required to update to node 16 etc.

packages/api/test/e2e/api.create.e2e.ts Outdated Show resolved Hide resolved
packages/types/src/types.ts Outdated Show resolved Hide resolved
packages/types/src/interfaces/injects.ts Outdated Show resolved Hide resolved
@KarishmaBothara
Copy link
Contributor Author

lgtm in general.
few commented code lines to tidy up
can you take note (for release notes/upgrade guide) of the breaking changes e.g. api.derive.staking => api.derive.cennzStaking, are users required to update to node 16 etc.

I am keeping a note of all the breaking changes and projects that would need to be updated for example (cennznet.io)
Since we are using the latest polkadot version it requires us to use one of the following
The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "12.21.0"

@KarishmaBothara KarishmaBothara merged commit fe5bab8 into develop Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants