-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.0 dev compatibile #407
Conversation
Things to do
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KarishmaBothara can't say that I fully understand this PR but I reckon it's good to merge and release the next alpha version to try it out.
Tests related to custom/slim metadata are all working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general.
few commented code lines to tidy up
can you take note (for release notes/upgrade guide) of the breaking changes e.g. api.derive.staking => api.derive.cennzStaking
, are users required to update to node 16 etc.
I am keeping a note of all the breaking changes and projects that would need to be updated for example (cennznet.io) |
With this PR,
generate:defs": "ts-node --skip-project node_modules/.bin/polkadot-types-from-defs --package @cennznet/types/interfaces --endpoint ./cennznet.json --input ./src/interfaces" (7.x typegen configuration (migration from 5.1.1) polkadot-js/api#4481)
https://github.com/polkadot-js/api/blob/master/packages/api-derive/src/bundle.ts#L23 (enable derive only if erasRewardPoints exist