Fix bug in return of method wrapped

cenobites · Nov 15, 2022 · 9c91e81 · 9c91e81
1 parent 4430ad7
commit 9c91e81
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/flask_jsonrpc/wrappers.py b/src/flask_jsonrpc/wrappers.py
@@ -41,7 +41,7 @@ def _method_has_parameters(self, fn: t.Callable[..., t.Any]) -> bool:
 
     def _method_has_return(self, fn: t.Callable[..., t.Any]) -> bool:
         fn_annotations = t.get_type_hints(fn)
-        return 'return' in fn_annotations
+        return 'return' in fn_annotations and fn_annotations['return'] is not type(None)
 
     def _validate(self, fn: t.Callable[..., t.Any]) -> bool:
         if not self._method_has_parameters(fn) and not self._method_has_return(fn):

diff --git a/tests/test_app.py b/tests/test_app.py
@@ -47,7 +47,7 @@ def index() -> str:
 
     # pylint: disable=W0612
     @jsonrpc.method('app.fn0')
-    def fn0():
+    def fn0() -> None:
         pass
 
     # pylint: disable=W0612
@@ -157,7 +157,7 @@ def test_app_create_with_method_without_annotation_on_params():
 
         # pylint: disable=W0612
         @jsonrpc.method('app.fn4')
-        def fn4():
+        def fn4() -> None:
             pass
 
         # pylint: disable=W0612