-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update main and quincy to include NFS on ARM #2102
Conversation
@@ -39,4 +39,16 @@ jobs: | |||
run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes | |||
|
|||
- name: build the ceph container arm64 image | |||
run: make BASEOS_REGISTRY=quay.io BASEOS_TAG=stream8 RELEASE="demo" BASEOS_REPO=centos/arm64v8 DAEMON_BASE_TAG="daemon-base:demo-centos-8-aarch64" DEMO_TAG="demo:demo-centos-stream8-aarch64" DAEMON_TAG="daemon:demo-centos-stream8-aarch64" FLAVORS="main,centos-arm64,8" build | |||
run: make BASEOS_REGISTRY=quay.io/centos BASEOS_TAG=stream8 RELEASE="demo" BASEOS_REPO=centos DAEMON_BASE_TAG="daemon-base:demo-centos-8-aarch64" DEMO_TAG="demo:demo-centos-stream8-aarch64" DAEMON_TAG="daemon:demo-centos-stream8-aarch64" FLAVORS="main,centos-arm64,8" build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated because we no longer need centos/arm64v8
and can just use centos/centos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, because of the shaman issue I mention in the description, I expect this to fail on main
at least on the first run, but it may not be a consistent failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is succeeding because the github runner is still an x86 system.
It might be good to make the arm builds do so via emulation, but it may be a fair bit of work: https://wiki.debian.org/QemuUserEmulation
run: make BASEOS_REGISTRY=quay.io BASEOS_TAG=stream8 RELEASE="demo" BASEOS_REPO=centos/arm64v8 DAEMON_BASE_TAG="daemon-base:demo-centos-8-aarch64" DEMO_TAG="demo:demo-centos-stream8-aarch64" DAEMON_TAG="daemon:demo-centos-stream8-aarch64" FLAVORS="main,centos-arm64,8" build | ||
run: make BASEOS_REGISTRY=quay.io/centos BASEOS_TAG=stream8 RELEASE="demo" BASEOS_REPO=centos DAEMON_BASE_TAG="daemon-base:demo-centos-8-aarch64" DEMO_TAG="demo:demo-centos-stream8-aarch64" DAEMON_TAG="daemon:demo-centos-stream8-aarch64" FLAVORS="main,centos-arm64,8" build | ||
|
||
arm64-quincy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this test to succeed since the quincy build takes NFS packages from the CentOS build service, and Kaleb got those builds working today.
@ktdreyer @andrewschoen do any of you know who can help regarding shaman build system?
yes, in fact it might be valid not only for nfs-ganesha? I guess it is still better to test with a recent build than nothing ? |
89c7942
to
267639f
Compare
I am chatting with Andrew Schoen to get a change into Shaman in the next few weeks to allow ceph-container to more reliably create ARM builds of images to facilitate my NFS v5 development. Shaman feature request tracked here: ceph/shaman#138 |
0f432f5
to
5c7a499
Compare
Update main and quincy build configs to include now-existing packages for NFS on ARM architectures. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Change to a case-statement-based method of choosing the NFS ganesha repo. This should keep bloat down while allowing reliable arm builds from shaman for ceph main. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
5c7a499
to
9b969a0
Compare
Closing in favor of #2162 |
Update main and quincy build configs to include now-existing packages for NFS on ARM architectures.
Latest update:
I am chatting with Andrew Schoen to get a change into Shaman in the next few weeks to allow ceph-container to more reliably create ARM builds of images to facilitate my NFS v5 development.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist: