Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated nose dependency with pynose #1947

Merged
merged 1 commit into from
May 23, 2024
Merged

replace deprecated nose dependency with pynose #1947

merged 1 commit into from
May 23, 2024

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented May 23, 2024

after upgrading teuthology to centos 9 and python 3.10, the rgw multisite test suite now fails to invoke nosetests with:

AttributeError: module 'collections' has no attribute 'Callable'

this is a known issue tracked in nose-devs/nose#1127

Shilpa found a new 'pynose' package which claims that:

This version of nose is compatible with Python 3.7+ (including 3.13+).

replace the nose dependency that i initially added in #1069 with the current version 1.5.1 of pynose

to prepare this pr, i first changed setup.cfg then ran:

./update-requirements.sh -P "pynose==1.5.1"

Fixes: https://tracker.ceph.com/issues/66183

after upgrading teuthology to centos 9 and python 3.10, the rgw
multisite test suite now fails to invoke nosetests with:

> AttributeError: module 'collections' has no attribute 'Callable'

this is a known issue tracked in nose-devs/nose#1127

Shilpa found a new 'pynose' package which claims that:

> This version of nose is compatible with Python 3.7+ (including 3.13+).

replace the nose dependency that i initially added in
#1069 with the current version
1.5.1 of pynose

to prepare this pr, i first changed setup.cfg then ran:

> ./update-requirements.sh -P "pynose==1.5.1"

Fixes: https://tracker.ceph.com/issues/66183

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Casey!

@cbodley
Copy link
Contributor Author

cbodley commented May 23, 2024

thanks @zmc. not sure this works yet, tests pending in https://pulpito.ceph.com/cbodley-2024-05-23_16:42:18-rgw:multisite-wip-boost-asio-spawn-unlock-distro-default-smithi/

i first tried https://pulpito.ceph.com/cbodley-2024-05-23_16:37:04-rgw:multisite-wip-boost-asio-spawn-unlock-distro-default-smithi/ but this wip-pynose branch hadn't made it to git.ceph.com yet?

cc @smanjara

@zmc
Copy link
Member

zmc commented May 23, 2024

Sounds good. If the tests pass, feel free to merge. If there are more issues, I can re-review.

@smanjara
Copy link

the tests failed due to multisite related errors. Scheduled a new run with two zone configuration

https://pulpito.ceph.com/smanjara-2024-05-23_19:43:45-rgw:multisite-wip-shilpa-multisite-tests-distro-default-smithi/7723368/

@cbodley cbodley merged commit e7ae758 into main May 23, 2024
8 checks passed
@cbodley cbodley deleted the wip-pynose branch May 23, 2024 20:28
@cbodley
Copy link
Contributor Author

cbodley commented Jul 9, 2024

@smanjara we'll likely need to reconsider use of this library based on licensing discussions in mdmintz/pynose#16

thanks @adamemerson for the heads-up

@smanjara
Copy link

smanjara commented Jul 9, 2024

@smanjara we'll likely need to reconsider use of this library based on licensing discussions in mdmintz/pynose#16

thanks @adamemerson for the heads-up

ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants