Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: context cleanup and graceful shutdown #16

Merged
merged 2 commits into from
Jul 9, 2023
Merged

feat: context cleanup and graceful shutdown #16

merged 2 commits into from
Jul 9, 2023

Conversation

smrz2001
Copy link
Collaborator

@smrz2001 smrz2001 commented Jul 6, 2023

No description provided.

@smrz2001 smrz2001 self-assigned this Jul 6, 2023
@linear
Copy link

linear bot commented Jul 6, 2023

RES-1111 Context cleanup and graceful shutdown

We're using context.Background() in a bunch of places and need to consolidate all the contexts into one server context coming from main. This will enable us to shut down services cleanly.

stephhuynh18
stephhuynh18 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@stephhuynh18 stephhuynh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contexts are useful but so verbose

@smrz2001 smrz2001 merged commit e757254 into develop Jul 9, 2023
1 check passed
@smrz2001 smrz2001 deleted the feature/res-1111-clean-up-contexts branch July 9, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephhuynh18 stephhuynh18 stephhuynh18 approved these changes

Assignees

@smrz2001 smrz2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smrz2001 @stephhuynh18