feat: flush batches at the top of the hour #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
approved these changes
Oct 3, 2024
smrz2001
deleted the
feature/aes-350-update-cas-scheduler-to-create-a-new-batch-just-after-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CAS Scheduler is responsible for generating batches for CAS Anchor Workers to anchor to Ethereum. Normally, it generates a batch either when it is full, or when its linger time has expired.
This PR adds another option where a batch will also be generated at a configurable interval. This allows batches to be generated at the top of the hour, allowing C1 nodes to ensure that they can submit their roots slightly before the top of the hour and get them included in the immediate next batch.
Without this option, C1 roots might end up waiting the full batch linger duration before they get included in a batch, which in turn might cause anchoring of events to get delayed by up to 1-2 hours, which is undesirable.