fix: use tokio::time::Interval for scheduling anchor batches #563
+46
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leverages the time math of skipping missed ticks etc. We are only left with computing the time when we should start the first tick. For this we use chrono and then rely on Interval for the heavy lifting.
stbrody
approved these changes
Oct 16, 2024
| @@ -76,28 +77,42 @@ impl AnchorService { | |||
| pin_mut!(shutdown_signal); | |||
|
|
|||
| info!("anchor service started"); | |||
| let period = | |||
There was a problem hiding this comment.
nitpick, but could we pull all this logic for building the interval into a helper function to improve readability?
| @@ -76,28 +77,42 @@ impl AnchorService { | |||
| pin_mut!(shutdown_signal); | |||
|
|
|||
| info!("anchor service started"); | |||
| let period = | |||
| TimeDelta::from_std(self.anchor_interval).expect("anchor interval should be in range"); | |||
| let buffer = period / 12; | |||
There was a problem hiding this comment.
its the buffer time we give ourselves to actually process the batch. I'll add a comment. For 1hour it ends up being 5 minutes.
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages the time math of skipping missed ticks etc. We are only left with computing the time when we should start the first tick. For this we use chrono and then rely on Interval for the heavy lifting.