Skip to content

Commit

Permalink
Do not depend on the alpine/edge (as resolved artifacts are dangling). (
Browse files Browse the repository at this point in the history
#33)

Do not depend on the alpine/edge (as resolved artifacts are dangling).
Instead depend on the stable `v3.18`.

In general it's a bad practice when `bazel test //...` brakes because
someone else (periodic) actions.

The same problem applies to Wolfi... (without artifacts cache).

After this PR: `bazel test //...` works.
  • Loading branch information
sfc-gh-ptabor authored Nov 29, 2023
1 parent 1ca116a commit 53076d1
Show file tree
Hide file tree
Showing 10 changed files with 900 additions and 1,000 deletions.
2 changes: 1 addition & 1 deletion e2e/smoke/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# smoke test

This e2e exercises the repo from an end-users perpective.
This e2e exercises the repo from an end-users perspective.
It catches mistakes in our install instructions, or usages that fail when called from an "external" repository to rules_apko.
It is also used by the presubmit check for the Bazel Central Registry.
34 changes: 17 additions & 17 deletions e2e/smoke/apko.resolved.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion e2e/smoke/apko.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
contents:
repositories:
- https://dl-cdn.alpinelinux.org/alpine/edge/main
- https://dl-cdn.alpinelinux.org/alpine/v3.18/main
packages:
- busybox

Expand Down
34 changes: 17 additions & 17 deletions examples/lock/apko.resolved.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions examples/lock/apko.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
contents:
repositories:
- https://dl-cdn.alpinelinux.org/alpine/edge/main
- https://dl-cdn.alpinelinux.org/alpine/v3.18/main
packages:
- busybox


# optional environment configuration
environment:
PATH: /usr/sbin:/sbin:/usr/bin:/bin
Expand All @@ -15,10 +14,9 @@ cmd: /bin/sh -l
# in the image
os-release:
id: alpine
version-id: '3.16.0'
name: 'Alpine Slim'
pretty-name: 'Alpine Slim (apko)'
version-id: "3.16.0"
name: "Alpine Slim"
pretty-name: "Alpine Slim (apko)"

archs:
- amd64

Loading

0 comments on commit 53076d1

Please sign in to comment.