pass correct apko binary runfiles path to apko_run launcher #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/sourcegraph/sourcegraph, we've defined our own apko toolchain to integrate a patch to go-apk for the apko binary. Due to this, we pass
register = False
toapko_register_toolchains
.This surfaced a correctness issue when trying to run
bazel run @rules_apko//apko
, with the following error:From the bazel docs on runfiles location, this particular quote highlights the correct way to build the path to the apko binary's runfile path: "The path to a File under the runfiles directory corresponds to File.short_path."
The change presented works both for our case, and also
bazel run //apko:apko
in the rules_apko repo 🙂