Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Python 3.12 (SCE-16) #2694

Merged
merged 1 commit into from
Sep 12, 2024
Merged

chore: Python 3.12 (SCE-16) #2694

merged 1 commit into from
Sep 12, 2024

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Sep 9, 2024

This PR adds support for python 3.12 to Annotate

Changes

  • Tested 3.12 with compatibility matrix
  • Added to push tests
  • Updated flatbuffers to 2.0.7 for python 3.12 compatibility
  • Updated node to 18
  • Added timeout to address flakiness (thanks @rainandbare !)
  • Updated docs

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (eb743ef) to head (957b1e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files          96       96           
  Lines        6654     6654           
  Branches      769      769           
=======================================
  Hits         4693     4693           
  Misses       1885     1885           
  Partials       76       76           
Flag Coverage Δ
frontend 70.52% <ø> (ø)
javascript 70.52% <ø> (ø)
unitTest 70.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster marked this pull request as draft September 9, 2024 21:18
@kaloster kaloster force-pushed the kaloster/python-312 branch 4 times, most recently from 7ff29e3 to 275acf5 Compare September 10, 2024 21:43
@kaloster kaloster changed the title chore: python 3.12 chore: python 3.12 (SCE-16) Sep 10, 2024
@kaloster kaloster marked this pull request as ready for review September 10, 2024 21:44
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HURRAY!! Such an amazing accomplishment 🤩 🏆 👏 👏 👏 Thank you for adding 3.12 compat and @rainandbare for fixing the flaky test 🔥 !!

@kaloster kaloster changed the title chore: python 3.12 (SCE-16) chore: Python 3.12 (SCE-16) Sep 11, 2024
@kaloster kaloster merged commit 487bd13 into main Sep 12, 2024
10 checks passed
@kaloster kaloster deleted the kaloster/python-312 branch September 12, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants