Skip to content

Commit

Permalink
upgrade eslint (#4800)
Browse files Browse the repository at this point in the history
* upgrade eslint

* fix lint rules

* reinstall old eas
  • Loading branch information
mattcasey authored Oct 14, 2024
1 parent 4812aba commit 45e108e
Show file tree
Hide file tree
Showing 6 changed files with 1,516 additions and 2,746 deletions.
15 changes: 8 additions & 7 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,25 +29,25 @@
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": ["@typescript-eslint", "react", "react-hooks"],
"plugins": ["@typescript-eslint", "@stylistic/ts", "react", "react-hooks"],
"rules": {
"react/jsx-key": "error",
"react/forbid-prop-types": 0,
"@next/next/no-img-element": "off",
"@typescript-eslint/array-type": "error",
"@typescript-eslint/ban-ts-comment": "off",
"@stylistic/ts/ban-ts-comment": "off",
"@typescript-eslint/consistent-type-imports": [
"error",
{
"prefer": "type-imports"
}
],
"@typescript-eslint/no-empty-function": "off",
"@stylistic/ts/no-empty-function": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/no-empty-interface": "off",
"@stylistic/ts/no-inferrable-types": "off",
"@stylistic/ts/no-empty-interface": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/member-delimiter-style": [
"@stylistic/ts/member-delimiter-style": [
"error",
{
"multiline": {
Expand All @@ -61,7 +61,7 @@
"multilineDetection": "brackets"
}
],
"@typescript-eslint/object-curly-spacing": ["error", "always"],
"@stylistic/ts/object-curly-spacing": ["error", "always"],
"object-curly-spacing": "off",
"arrow-body-style": "off",
"arrow-parens": "off",
Expand All @@ -78,6 +78,7 @@
"devDependencies": true,
"packageDir": [
"./",
"../..",
"./@connect-shared",
"./apps/cron/",
"./apps/farcaster/",
Expand Down
2 changes: 1 addition & 1 deletion apps/farcaster/next-env.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/basic-features/typescript for more information.
// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ export function mapActivityToRow(notification: ScoutGameNotification) {
? notification.type === 'gems_first_pr'
? 'First contribution!'
: notification.type === 'gems_third_pr_in_streak'
? 'Contribution streak!'
: 'Contribution accepted!'
? 'Contribution streak!'
: 'Contribution accepted!'
: 'Builder scored!';
subtitle =
notification.recipientType === 'builder' ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ export function getActivityLabel(activity: BuilderActivity) {
? activity.contributionType === 'first_pr'
? 'First CONTRIBUTION'
: activity.contributionType === 'regular_pr'
? 'Contribution ACCEPTED'
: activity.contributionType === 'third_pr_in_streak'
? 'Contribution STREAK'
: activity.contributionType === 'daily_commit'
? 'Daily COMMIT'
: null
? 'Contribution ACCEPTED'
: activity.contributionType === 'third_pr_in_streak'
? 'Contribution STREAK'
: activity.contributionType === 'daily_commit'
? 'Daily COMMIT'
: null
: activity.type === 'nft_purchase'
? 'Scouted by'
: null;
? 'Scouted by'
: null;
}

export function BuilderActivityLabel({ activity }: { activity: BuilderActivity }) {
Expand Down
Loading

0 comments on commit 45e108e

Please sign in to comment.