Convert cron, ceramic and websockets into monorepo apps #4556

mattcasey · 2024-09-07T16:59:10Z

enables us to remove some dependencies from the global package.json
make clear and standardized boundaries between apps
will make future cleanup easier
standardize deployment

Tested:

Deploy cron to staging
Deploy ceramic to staging
Deploy websockets to staging

Devorein · 2024-09-09T12:21:20Z

.github/actions/build/action.yml

        key: webapp-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/*.ts', '**/*.tsx', '**/*.gql', '**/*.scss', '!node_modules', '!.next', '!dist', '!apps') }}
        restore-keys: |
          webapp-${{ hashFiles('**/package-lock.json') }}-

    - name: Build
      shell: bash
      if: steps.restore_build.outputs.cache-hit != 'true'
-      run: npm run build


Are we not going to save the build cache anymore 😮

Devorein · 2024-09-09T12:23:23Z

.github/actions/build_app/action.yml

Why do we have two separate build actions? Can't we use this one for building the webapp too?

the webapp should eventually use build_app but first we should make it a workspace app

Devorein · 2024-09-09T12:31:08Z

.github/actions/install/action.yml

@@ -39,13 +43,14 @@ runs:
        path: |
          ./node_modules
          ./apps/*/node_modules


Shouldn't we only include the node_modules in the correct app rather than ./apps/*/node_modules?

they won't be built so there's nothing to be copied

Devorein · 2024-09-09T12:34:15Z

.github/workflows/deploy_cron.yml

+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          AWS_REGION: us-east-1
+        with:
+          ecr_registry: cron


I like that we are using a separate registry for cron. I believe previously we were using the webapp one

Devorein · 2024-09-09T12:36:33Z

.github/workflows/deploy_scoutgame.yml

@@ -138,7 +136,7 @@ jobs:
          file_extensions: '**/*.{ts,tsx}'

      - name: Run tests
-        run: npm run test -w apps/scoutgame


When testing cron we are using the -w apps/cron format. But for scoutgame and I assume other non webapp apps we are using app_name:test format. Shouldn't we stick to a single format?

Devorein · 2024-09-09T12:40:11Z

.github/workflows/deploy_websockets.yml

+
+      - name: Update Dockerfile
+        run: |
+          rm Dockerfile && mv apps/websockets/Dockerfile Dockerfile


Love that now each app have their own ecr registry along with Dockerfile

Devorein · 2024-09-09T13:31:53Z

apps/websockets/package.json

+    "typecheck": "../../node_modules/typescript/bin/tsc --project ./tsconfig.json  --noEmit"
+  },
+  "dependencies": {
+    "@packages/charmeditor": "^1.0.0"


Nice I didn't know you could do that 😮

Devorein · 2024-09-09T13:35:45Z

docker-compose.yml

  prd-sockets:
    extends:
      service: defaults
    ports:
      - '80:3000'
-    command: ['sh', '-c', 'node ./dist/initWebsockets.js']
+    command: ['sh', '-c', 'node ./apps/websockets/dist/initWebsockets.js']


Shouldn't we use an npm command like npm run websockets:start:prod or something?

we're using node directly in this file. there is a difference when you use npm, i think it changes how the process gets run inside of docker but unfortunately i don't recall the issue we were addressing anymore. so for now it's also to be consistent

mattcasey added 2 commits September 7, 2024 10:46

clean up sub-apps

de44201

add yml for websockets and cron

bf75c79

mattcasey changed the title ~~Convert cron and websockets into monorepo apps~~ Convert cron, ceramic and websockets into monorepo apps Sep 7, 2024

mattcasey added 4 commits September 7, 2024 11:11

fix install

3ec9de6

fix types for theme

3cbd853

add test env files

a0acd34

add test command to sockets

f3ea4db

mattcasey added the 🚀 deploy-cron label Sep 7, 2024

mattcasey added 14 commits September 7, 2024 11:49

fix socket tests

7c11591

add test command for scouts

cc45102

add docker files

9526f51

fix types

65468d5

fix dockerfile

3771435

fix install args

474333f

fix tpl

0bb515b

..

75d2cd7

fix script

25adbff

fix checkout

e71acf5

add to staging cleanup

42ad90e

add to destroy staging

2e5ec8d

pass secrest in

6159a9f

remove env

9292e6f

github-actions bot temporarily deployed to stg-cron-4556-cron-app September 7, 2024 21:11 Destroyed

ci everything

4e97d50

github-actions bot temporarily deployed to stg-cron-4556-cron-app September 8, 2024 00:55 Destroyed

rebuild npm

ea4f8fd

github-actions bot temporarily deployed to stg-cron-4556-cron-app September 8, 2024 01:57 Destroyed

try installing again

988f896

github-actions bot temporarily deployed to stg-cron-4556-cron-app September 8, 2024 02:20 Destroyed

remove use of dotenv

2a3dc8f

github-actions bot temporarily deployed to stg-webapp-4556-cron-app September 9, 2024 04:10 Destroyed

github-actions bot temporarily deployed to stg-websockets-4556-cron-app September 9, 2024 04:17 Destroyed

github-actions bot temporarily deployed to stg-webapp-4556-cron-app September 9, 2024 04:50 Destroyed

dont use special port

5dcc56d

github-actions bot temporarily deployed to stg-webapp-4556-cron-app September 9, 2024 05:38 Destroyed

cleanup webapp build

ac52dca

github-actions bot temporarily deployed to stg-websockets-4556-cron-app September 9, 2024 05:47 Destroyed

fix socket staging

2b5bb01

github-actions bot temporarily deployed to stg-webapp-4556-cron-app September 9, 2024 06:01 Destroyed

github-actions bot temporarily deployed to stg-websockets-4556-cron-app September 9, 2024 06:13 Destroyed

Devorein reviewed Sep 9, 2024

View reviewed changes

Devorein approved these changes Sep 9, 2024

View reviewed changes

mattcasey added 3 commits September 9, 2024 09:46

..

9d2cc3c

fix eslint

9a5eef0

merge main

6e19f3c

github-actions bot temporarily deployed to stg-webapp-4556-cron-app September 9, 2024 16:45 Destroyed

github-actions bot temporarily deployed to stg-websockets-4556-cron-app September 9, 2024 16:56 Destroyed

fix e2e for webapp

b3ebbcf

github-actions bot deployed to stg-webapp-4556-cron-app September 9, 2024 17:31 View deployment

fix staging again

ac841d2

github-actions bot deployed to stg-websockets-4556-cron-app September 9, 2024 17:42 View deployment

mattcasey merged commit 861f7e4 into main Sep 9, 2024
57 checks passed

mattcasey deleted the cron-app branch September 9, 2024 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert cron, ceramic and websockets into monorepo apps #4556

Convert cron, ceramic and websockets into monorepo apps #4556

mattcasey commented Sep 7, 2024 •

edited

Loading

Devorein Sep 9, 2024

Devorein Sep 9, 2024

mattcasey Sep 9, 2024

Devorein Sep 9, 2024

mattcasey Sep 9, 2024

Devorein Sep 9, 2024

Devorein Sep 9, 2024 •

edited

Loading

mattcasey Sep 9, 2024

Devorein Sep 9, 2024

Devorein Sep 9, 2024

Devorein Sep 9, 2024

mattcasey Sep 9, 2024 •

edited

Loading

Convert cron, ceramic and websockets into monorepo apps #4556

Convert cron, ceramic and websockets into monorepo apps #4556

Conversation

mattcasey commented Sep 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Devorein Sep 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattcasey Sep 9, 2024 • edited Loading

Choose a reason for hiding this comment

mattcasey commented Sep 7, 2024 •

edited

Loading

Devorein Sep 9, 2024 •

edited

Loading

mattcasey Sep 9, 2024 •

edited

Loading