Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scout game user optimisations #4844

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Scout game user optimisations #4844

merged 10 commits into from
Oct 21, 2024

Conversation

valentinludu
Copy link
Collaborator

@valentinludu valentinludu commented Oct 18, 2024 •
edited
Loading

  • make user provider more practical
  • Cache all scout requests just for the url the user is requesting. Every time the url is changed, the cache will be invalid and cached again for the next requests.

@valentinludu valentinludu changed the title Scout game user optimisations Scout game user optimisations - WIP Oct 18, 2024
@valentinludu valentinludu changed the title Scout game user optimisations - WIP Scout game user optimisations Oct 21, 2024
Devorein
Devorein approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Devorein Devorein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome refactor 🚀

@valentinludu valentinludu merged commit 239f7e1 into main Oct 21, 2024
80 checks passed
@valentinludu valentinludu deleted the feat/sg-optimizations branch October 21, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devorein Devorein Devorein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinludu @Devorein