Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent calling fromAttribute when attribute set by property. #137

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

edoardocavazza
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: edda1be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chialab/dna Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 69.54%. Comparing base (8ae7c63) to head (edda1be).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Component.ts 76.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   69.50%   69.54%   +0.03%     
==========================================
  Files          13       13              
  Lines        4201     4196       -5     
  Branches      263      264       +1     
==========================================
- Hits         2920     2918       -2     
+ Misses       1084     1080       -4     
- Partials      197      198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edoardocavazza edoardocavazza merged commit 69b8774 into main Apr 29, 2024
19 checks passed
@edoardocavazza edoardocavazza deleted the reflect-attribute-lifecycle branch April 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant