Expose method const-qualification in func_overloads_types - #1
Merged
Conversation
conrade-ctc
force-pushed
the
ctc-master
branch
from
August 31, 2026 16:17
52452d7 to
8a820f5
Compare
rathorey-ctc
force-pushed
the
rathorey/func-overloads-is-const
branch
from
August 31, 2026 16:28
f7c8c03 to
58c8b22
Compare
Test Results
|
* [cpyrt] Add per-overload 'is_const' to GetSignatureTypes * [test] Add regression test for overload constness reporting Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
rathorey-ctc
force-pushed
the
rathorey/func-overloads-is-const
branch
from
August 31, 2026 19:54
58c8b22 to
18f6be1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a per-overload
is_constfield to thefunc_overloads_typesmetadata dict(
cpyrt::CPPMethod::GetSignatureTypes), routed through the existinginterop::IsConstMethodchain. AlwaysFalsefor free functions and staticmethods. Additive —
return_type/input_typesunchanged; consumers read keysindividually.
Motivation: a downstream consumer needs to classify reflected methods as const
vs non-const for validation; constness was previously not recoverable from
Python.
Intended release:
ctc.34.Test evidence:
test17_func_overloads_types_reports_constnessintest/test_overloads.py(red at the base branch:KeyError: 'is_const').